fix(lemonslice): bind avatar audio output before the upstream session HTTP call#5837
Merged
Merged
Conversation
… HTTP call Rebinding agent_session.output.audio happened after the LemonSlice session HTTP call returned, which is on the order of a second and during a persona swap leaves any generations triggered in the gap routed to the previous audio destination. wait_remote_track buffers frames until the new video track shows up, so binding before the HTTP call doesn't drop audio.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebind
agent_session.output.audioto the avatar-boundDataStreamAudioOutputbefore the LemonSlice session-creation HTTP call instead of after. The call is on the order of a second, and during a mid-session avatar swap anygenerate_replytriggered in that gap stays routed to the previous audio destination.wait_remote_track=KIND_VIDEObuffers frames until the new video track actually shows up, so binding early doesn't drop audio.Test plan