fix(voice): reset user turn tracker on clear_user_turn#5857
Merged
Conversation
clear_user_turn() resets every per-turn state field except _turn_tracker, so word count, transcript, and started_at carry over from a discarded turn into the next one. With user_turn_limit configured, a push-to-talk cancel followed by a new turn can trip max_words or max_duration prematurely (duration in particular compares against the canceled turn's start time). Fixes #5851.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clear_user_turn()resets every per-turn state field except_turn_tracker, so word count, transcript, andstarted_atcarry over from a discarded turn into the next one. Withuser_turn_limitconfigured, a push-to-talk cancel followed by a new turn can tripmax_wordsormax_durationprematurely.Fixes #5851.