fix(voice): block on_user_turn_exceeded during agent handoff#5858
Merged
Conversation
Other user-turn handlers check `_scheduling_paused or _new_turns_blocked` before scheduling, but `on_user_turn_exceeded` was missing that guard. If the event fires inside the transition window opened by `update_agent()`, the old activity schedules a speech task — delaying drain and making the old agent respond instead of the new one. Add the guard at entry and a matching re-check inside `_user_turn_exceeded_task` after the wait phase so an already-running task self-aborts when a handoff starts mid-wait.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
davidzhao
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block
on_user_turn_exceededduring agent handoff:on_user_turn_exceededblocks new tasks_user_turn_exceeded_taskafter the wait phase aborts a task that was already in flight when the transition started; placed before the lock so it respects the existing "never cancel user code" ruleCloses #5852.