fix(job): close RecorderIO at session end if session close was interrupted#5927
Merged
Conversation
…upted Complements #5926. When session.aclose() is cancelled during job shutdown (e.g. by the aclose timeout), it can return before RecorderIO.aclose() is reached, leaving the recorder still recording. make_session_report() then raises and the error propagates out of _on_session_end, preventing the registered shutdown callbacks from running. This closes RecorderIO at session end if it is still recording, and wraps _on_session_end() so a failure there no longer blocks the shutdown callbacks.
theomonnom
approved these changes
Jun 2, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complements #5926.
When
session.aclose()is cancelled during job shutdown (e.g. by the aclose timeout), it can return beforeRecorderIO.aclose()is reached, leaving the recorder still recording.make_session_report()then raises and the error propagates out of_on_session_end, preventing the registered shutdown callbacks from running.This closes
RecorderIOat session end if it is still recording, and wraps_on_session_end()so a failure there no longer blocks the shutdown callbacks.