Skip to content

fix IllegalArgumentException when rpc is over 15K#902

Merged
xianshijing-lk merged 2 commits intomainfrom
sxian/fix_rpc_over15k_exception
Mar 27, 2026
Merged

fix IllegalArgumentException when rpc is over 15K#902
xianshijing-lk merged 2 commits intomainfrom
sxian/fix_rpc_over15k_exception

Conversation

@xianshijing-lk
Copy link
Copy Markdown
Contributor

The current code will thro a IllegalArgumentException when RPC is over 15K
While the function comment says that it will return failure containing the exception

@xianshijing-lk xianshijing-lk requested a review from davidliu March 26, 2026 23:45
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: fe0c959

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Diffuse output:

OLD: diffuse-source-file
NEW: livekit-android-sdk-release.aar

 AAR      │ old      │ new      │ diff  
──────────┼──────────┼──────────┼───────
      jar │    4 MiB │    4 MiB │ +33 B 
 manifest │  1.5 KiB │  1.5 KiB │   0 B 
 lint-jar │ 12.7 KiB │ 12.7 KiB │   0 B 
    other │  1.8 KiB │  1.8 KiB │   0 B 
──────────┼──────────┼──────────┼───────
    total │    4 MiB │    4 MiB │ +33 B 

 JAR     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
 classes │  2209 │  2209 │ 0 (+0 -0) 
 methods │ 42967 │ 42967 │ 0 (+0 -0) 
  fields │  8382 │  8382 │ 0 (+0 -0)
AAR
 size  │ diff  │ path          
───────┼───────┼───────────────
 4 MiB │ +33 B │ ∆ classes.jar 
───────┼───────┼───────────────
 4 MiB │ +33 B │ (total)

@xianshijing-lk
Copy link
Copy Markdown
Contributor Author

Thanks @davidliu

@xianshijing-lk xianshijing-lk merged commit eea6e87 into main Mar 27, 2026
6 checks passed
@xianshijing-lk xianshijing-lk deleted the sxian/fix_rpc_over15k_exception branch March 27, 2026 15:23
@davidliu davidliu mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants