Merged
Conversation
xianshijing-lk
approved these changes
Apr 23, 2026
stephen-derosa
approved these changes
Apr 23, 2026
Contributor
stephen-derosa
left a comment
stephen-derosa
left a comment
There was a problem hiding this comment.
awesome thanks for doing this! FMU: with this MR do we expect clang-tidy to return no errors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on PR from #97 to enable
misc-const-correctnesscheck and apply fixes where it makes sense to.Note that on an entire repo run for this check, there were some areas of the code that required minor refactors to achieve
conston the flagged lines. I opted not to touch these areas (not worth risk of changing), and they're not flagged because thecpp-linteris only set to check changed lines.