clang-tidy environmental consistency#109
Merged
Merged
Conversation
… into bugfix/clang-tidy
stephen-derosa
approved these changes
Apr 28, 2026
Collaborator
stephen-derosa
left a comment
stephen-derosa
left a comment
There was a problem hiding this comment.
LGTM -- i think all the checks so far make sense
…test for track publication
alan-george-lk
changed the title
Commit 64cb6cf inadvertently rewrote CMakePresets.json from CRLF to LF (no content change). Restore the file to match origin/main so the PR diff stays focused on the clang-tidy work. Made-with: Cursor
xianshijing-lk
approved these changes
Apr 29, 2026
stephen-derosa
approved these changes
Apr 29, 2026
Collaborator
stephen-derosa
left a comment
stephen-derosa
left a comment
There was a problem hiding this comment.
in general lgtm, a few questions/comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
cpp-linteraction with a custom script + GitHub actions steps instead. The intent is to enable local running of these checks in an identical way to CI. While convenient,cpp-linterran inputs toclang-tidya certain way, and matching that locally proved challenging.Overview of changes:
clang-tidy.shscriptTo run locally:
Which runs and logs output to
clang-tidy.log(now.gitignore'd for all.logfiles). Has convenience prints at the end too:Results written to: /Users/alan.george/LiveKit/client-sdk-cpp/clang-tidy.log ------------------------------------------------------------ clang-tidy summary: 1 warning(s), 0 error(s) by check: bugprone-exception-escape 1 ------------------------------------------------------------A GitHub-actions integration was also added to maintain feature parity.
Examples of how the PR annotations appear:
error
warning
Testing
All integration tests passed locally: