Visibility controls on public API#121
Merged
Merged
Conversation
…truly_private_spdlog
…truly_private_spdlog
alan-george-lk
commented
May 11, 2026
alan-george-lk
commented
May 11, 2026
stephen-derosa
approved these changes
May 11, 2026
Collaborator
stephen-derosa
left a comment
There was a problem hiding this comment.
LGTM -- is there any test we can run to make sure we arent missing the LIVEKIT_API macro for items that should be public?
xianshijing-lk
approved these changes
May 11, 2026
Collaborator
xianshijing-lk
left a comment
There was a problem hiding this comment.
lgtm assuming the check will be moved to release CI flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
LIVEKIT_APImacro to expose LiveKit API symbols across platforms (common convention, example)#include "livekit/<blah"convention, updatedAGENTS.mdto define this rulespdlogwas installed at the system level in CI (and documented for users to install at that level), but was brought in viaFetchContent/vcpkg. This is no longer needed (system install). Removed that flow and deprecated the CMake argument/functionality for using system levelspdlog. It is now entirely within the SDK and fully private/no symbols exposed to clashTesting
spdlogclash with third-party lib)spdlog:process has deied [pid 5915, exit code -7...tests.ymlCI stage to catch this across all OS moving forward, with the small caveat that we need to ensure any new deps are added to the symbol check