Fix visibility for RPC#129
Merged
stephen-derosa merged 1 commit intoMay 14, 2026
Merged
Conversation
stephen-derosa
requested review from
alan-george-lk and
xianshijing-lk
as code owners
stephen-derosa
commented
May 14, 2026
stephen-derosa
force-pushed
the
sderosa/bugfix/BOT-360-fix-rpc-vis
branch
2 times, most recently
from
9904d26 to
e89a358
Compare
stephen-derosa
force-pushed
the
sderosa/bugfix/BOT-360-fix-rpc-vis
branch
from
e89a358 to
973a8b9
Compare
alan-george-lk
approved these changes
May 14, 2026
Collaborator
alan-george-lk
left a comment
alan-george-lk
left a comment
There was a problem hiding this comment.
Approved, thanks. If we run into future issues I think we can verbatim use the one here (with our own LIVEKIT_API labels): https://gcc.gnu.org/wiki/Visibility
But for now this generally matches what we want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alan-george-lk summary of what's going on here:
livekit::RpcErrorwas caught in an error-condition test. This error extendsstd::runtime_error.dylibtype info behavior is different than on Linux, which does run and pass these integration testslivekit::RpcErrortype so it can be correctly caught (on Mac)This likely would have popped up in other ways as consumers used the SDK and wanted to inherit from our types (on Mac).