Skip to content

Unify clang-tidy args/GitHub summary output with clang-format#150

Merged
alan-george-lk merged 4 commits into
mainfrom
feature/cleaner_clang
Jun 2, 2026
Merged

Unify clang-tidy args/GitHub summary output with clang-format#150
alan-george-lk merged 4 commits into
mainfrom
feature/cleaner_clang

Conversation

@alan-george-lk
Copy link
Copy Markdown
Collaborator

@alan-george-lk alan-george-lk commented Jun 1, 2026

This PR does the following:

  • Allow developer to pass in file path to ./scripts/clang-tidy.sh <file> just like clang-format.sh to analyze a single file
  • Add --fix arg to match clang-format.sh
  • Updated GitHub summary view to look more similar on success
Screenshot 2026-06-01 at 4 11 33 PM

@alan-george-lk alan-george-lk marked this pull request as ready for review June 1, 2026 22:33
Comment thread scripts/clang-tidy.sh Outdated
__tidy_hint_active=0
exit 0
;;
--fix|-fix|-i)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious the choice of --fix, -fix and -i -- why not just --fix?

Copy link
Copy Markdown
Collaborator Author

@alan-george-lk alan-george-lk Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, was thinking of keeping the old -fix and -i is a common "input file" short hand, but not super useful here.

@alan-george-lk alan-george-lk changed the title Unify clang-tidy args/github output with format Unify clang-tidy args/GitHub summary output with clang-format Jun 1, 2026
@alan-george-lk alan-george-lk merged commit 245d55c into main Jun 2, 2026
17 checks passed
@alan-george-lk alan-george-lk deleted the feature/cleaner_clang branch June 2, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants