Skip to content

spdlog is now private#84

Merged
stephen-derosa merged 6 commits intolivekit:mainfrom
stephen-derosa:sderosa/fix/spdlog-dep
Apr 8, 2026
Merged

spdlog is now private#84
stephen-derosa merged 6 commits intolivekit:mainfrom
stephen-derosa:sderosa/fix/spdlog-dep

Conversation

@stephen-derosa
Copy link
Copy Markdown
Contributor

@stephen-derosa stephen-derosa commented Apr 2, 2026

Building against release 0.3.2 causes error:

-- [download 99% complete]
-- [download 100% complete]
-- LiveKitSDK: extracting /home/runner/work/cpp-example-collection/cpp-example-collection/build/_downloads/livekit-sdk-linux-x64-0.3.2.tar.gz
-- LiveKitSDK: using SDK at /home/runner/work/cpp-example-collection/cpp-example-collection/build/_deps/livekit-sdk/livekit-sdk-linux-x64-0.3.2
CMake Error at /usr/local/share/cmake-3.31/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "Findspdlog.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "spdlog", but
  CMake did not find one.

  Could not find a package configuration file provided by "spdlog" with any
  of the following names:

    spdlogConfig.cmake
    spdlog-config.cmake

  Add the installation prefix of "spdlog" to CMAKE_PREFIX_PATH or set
  "spdlog_DIR" to a directory containing one of the above files.  If "spdlog"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  build/_deps/livekit-sdk/livekit-sdk-linux-x64-0.3.2/lib/cmake/LiveKit/LiveKitConfig.cmake:28 (find_dependency)
  CMakeLists.txt:38 (find_package)


-- Configuring incomplete, errors occurred!

This MR adds a build against an external project in CI to test cmake linking. It depends on this work

I brought in the github action client build commit into this MR to include the test of the fix!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the CMake configuration for the vendored spdlog dependency so that spdlog’s own install rules are enabled when fetched via FetchContent on macOS/Linux.

Changes:

  • Enable SPDLOG_INSTALL for the vendored spdlog build (OFFON).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephen-derosa stephen-derosa force-pushed the sderosa/fix/spdlog-dep branch from 1e66fd0 to 3bdf79a Compare April 2, 2026 20:40
@stephen-derosa stephen-derosa added the bug Something isn't working label Apr 2, 2026
@stephen-derosa stephen-derosa changed the title SPDLOG_INSTALL ON spdlog is now private Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@xianshijing-lk xianshijing-lk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@stephen-derosa stephen-derosa merged commit 977ae2a into livekit:main Apr 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants