Better audio management #10
Conversation
disposing if already published causes exception.
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
looks good! I noticed how it fixed a few of the bugs that I had ran into as well.
Only Q about audio track options.
example/ios/Runner/Info.plist
Outdated
| <key>UIBackgroundModes</key> | ||
| <array> | ||
| <string>audio</string> | ||
| <string>fetch</string> |
There was a problem hiding this comment.
do we need these? it seems like audio is the only mode we should have.
There was a problem hiding this comment.
removed! was figuring out why background audio wasnt working.
example/lib/widgets/controls.dart
Outdated
| import 'package:eva_icons_flutter/eva_icons_flutter.dart'; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:livekit_client/livekit_client.dart'; | ||
| import 'package:livekit_client/src/track/audio_track.dart'; |
| } | ||
|
|
||
| // doesn't make sense to negotiate if already disposed | ||
| if (!isDisposed) { |
There was a problem hiding this comment.
can this logic be encapsulated within engine.negotiate?
There was a problem hiding this comment.
currently engine gets disposed later ..... so I might need to restructure things...
| abstract class Participant extends LKChangeNotifier { | ||
| abstract class Participant extends DisposeAwareChangeNotifier { | ||
| /// map of track sid => published track | ||
| final trackPublications = <String, TrackPublication>{}; |
There was a problem hiding this comment.
why was this changed to a Set? IIRC, Set makes it hard to do get publication by sid. Though we don't expect the performance to be an issue.. just curious on the choice to change it.
There was a problem hiding this comment.
Yes I was going to revert this 😅 lookup is harder.
|
Background audio now works |
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
great stuff! are we good to merge then? oh, it'd be great to clean up some of the lines that are commented out too.
| } | ||
|
|
||
| // doesn't make sense to negotiate if already disposed | ||
| if (!isDisposed) { |
I'll merge today after clean ups and checks! |
2 participants
Known issues
recordcategory.Fix