Skip to content

Prevent crashes from writing to closed data stream controllers#989

Merged
hiroshihorie merged 3 commits intomainfrom
hiroshi/fix-data-stream-closed-state
Feb 11, 2026
Merged

Prevent crashes from writing to closed data stream controllers#989
hiroshihorie merged 3 commits intomainfrom
hiroshi/fix-data-stream-closed-state

Conversation

@hiroshihorie
Copy link
Member

Changes:

  • Add isClosed guards to write(), error(), and close() on DataStreamController
  • Fix fallthrough bug in handleStreamChunk where a chunk would still be written after an encryption mismatch error
  • Close stream controllers in validateParticipantHasNoActiveDataStreams after sending the error, so readAll() consumers don't hang indefinitely

Closes #978

@hiroshihorie hiroshihorie merged commit f225dca into main Feb 11, 2026
16 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/fix-data-stream-closed-state branch February 11, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant