Harden extension computation and retry publishing on negotiation failure#1895
Merged
Harden extension computation and retry publishing on negotiation failure#1895
Conversation
…sion reassignment bug
🦋 Changeset detectedLatest commit: 8226d99 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lukasIO
requested review from
1egoman,
boks1971 and
xianshijing-lk
and removed request for
1egoman and
boks1971
…s into lukas/extension-fix
lukasIO
commented
Apr 17, 2026
| if (this.ddExtID === 0) { | ||
| let maxID = 0; | ||
| sdp.media.forEach((m) => { | ||
| if (m.type !== 'video') { |
Contributor
Author
There was a problem hiding this comment.
this is supposed to ensure that we're not reusing any extension ids (be it audio or video)
boks1971
approved these changes
Apr 17, 2026
Contributor
boks1971
left a comment
boks1971
left a comment
There was a problem hiding this comment.
lgtm, but would be good to get another set of 👀 as I do not understand all the nuances of paths invoved.
lukasIO
changed the title
Contributor
Author
|
going to merge this for now. @1egoman if you get a chance, I'd appreciate your 👀 on it still |
This was referenced Apr 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.