fix: ensure updated tokens get set on the regionUrlProvider#1900
Merged
fix: ensure updated tokens get set on the regionUrlProvider#1900
Conversation
lukasIO
changed the title
🦋 Changeset detectedLatest commit: 1ae31ce The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
1egoman
approved these changes
Apr 20, 2026
Comment on lines
-1140
to
-1144
| if (this.token && this.regionUrlProvider) { | ||
| // token may have been refreshed, we do not want to recreate the regionUrlProvider | ||
| // since the current engine may have inherited a regional url | ||
| this.regionUrlProvider.updateToken(this.token); | ||
| } |
Contributor
There was a problem hiding this comment.
question: Should there also be a this.emit(EngineEvent.TokenRefreshed, token); here?
Contributor
Author
There was a problem hiding this comment.
good question. this should not be needed anymore as we're passing the token along at each token refreshed event, adding it nonetheless to ensure this isn't breaking any previous expectations.
…/client-sdk-js into lukas/url-provider-token-refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and a small refactor to avoid the duplicate ownership of regionUrlProvider in both room and engine
closes #1849