Re-compute encoding params after device change#1902
Conversation
🦋 Changeset detectedLatest commit: 1bde530 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
two questions, lgtm if you address them
| }); | ||
|
|
||
| await this.applyEncodingsToSender(this.sender, newEncodings); | ||
| this.encodings = newEncodings; |
There was a problem hiding this comment.
what will happen if setParameters fails at the above this.applyEncodingsToSender( ?
It looks like we still continue and set the encodings ?
Is it intentional ?
There was a problem hiding this comment.
that's a good point, I moved things around and it fits quite nicely with pushing the senderLock one level higher
| ...this.publishOptions, | ||
| }); | ||
|
|
||
| await this.applyEncodingsToSender(this.sender, newEncodings); |
There was a problem hiding this comment.
what is the thread model for this LocalVideoTrack.ts? will it be called by multi threads?
I wonder if this.sender would have been changed when it gets here, given things are async like
dims = await this.waitForDimensions();
There was a problem hiding this comment.
the sender property should only ever be set once for a given LocalTrack. We can think about moving the senderLock one level higher into refreshSenderEncodings. I'll do that now to be safe
3 participants
closes #1884