Ensure priority isn't set on all simulcast layers when using Firefox on iOS#1920
Ensure priority isn't set on all simulcast layers when using Firefox on iOS#1920
Conversation
🦋 Changeset detectedLatest commit: dc20e08 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| import { | ||
| compareVersions, | ||
| getReactNativeOs, | ||
| isFireFox, |
There was a problem hiding this comment.
Just a followup, but do we need to treat Firefox on iOS differently in general? I mean in these other cases:
https://github.com/search?q=repo%3Alivekit%2Fclient-sdk-js%20isFireFox&type=code
There was a problem hiding this comment.
that's a good point. The other instances are more about "preventing an advanced feature for FF" which won't result in an actual issue, but certainly isn't the greatest experience.
Worth investigating whether isFirefox should only ever return true on non-iOS versions.
2 participants
Priority can be set on all layers only when using Firefox.
On iOS the underlying browser engine is still Webkit so we need to guard against wrongly treating it as Firefox.