Improve video frame conversion logic#203
Merged
MaxHeimbrock merged 6 commits intomainfrom Mar 27, 2026
Merged
Conversation
MaxHeimbrock
changed the title
Contributor
Author
|
Proof of improved GPU color conversion: |
xianshijing-lk
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
=============================================
We only mirrored in GPU YUV conversion path and also did not have the shader in a resource folder, so you had to manually specify it in graphics settings to be included in platform builds.
In resource builds the shader now gets included in all builds automatically. So the CPU fallback is not used anymore, and if it was I also added the mirror to the CPU path as well.
I did the same for the resizing shader in the Meet example and also did a small addition to .gitignore on the side.
The YUV to RGBA conversion shader was using wrong assumptions about sRGB and ARGB color spaces. That is why the conversion looked wrong with a too bright image.