Mark _muted and _disposed as volatile in RtcAudioSource#227
Merged
MaxHeimbrock merged 1 commit intomainfrom Apr 10, 2026
Merged
Mark _muted and _disposed as volatile in RtcAudioSource#227MaxHeimbrock merged 1 commit intomainfrom
MaxHeimbrock merged 1 commit intomainfrom
Conversation
These fields are written on the main thread (SetMute, Dispose) and read on the audio callback thread (OnAudioRead). Without volatile, the audio thread may not see updates promptly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
These fields are written on the main thread (SetMute, Dispose) and read on the audio callback thread (OnAudioRead). Without volatile, the audio thread may not see updates promptly. Volatile forces the value to be read from memory instead of potentially the CPU cache.
Changes
What did you do?
_mutedand_disposedas volatile