Add generic FfiInstruction base classes, simplify 8 instruction types#231
Merged
MaxHeimbrock merged 2 commits intomainfrom Apr 13, 2026
Merged
Add generic FfiInstruction base classes, simplify 8 instruction types#231MaxHeimbrock merged 2 commits intomainfrom
MaxHeimbrock merged 2 commits intomainfrom
Conversation
Introduce FfiInstruction<TCallback> and FfiStreamInstruction<TCallback> as generic base classes for the common one-shot FFI callback pattern. Replace 8 identical instruction classes with thin subclasses that delegate to the base, eliminating ~200 lines of duplicated boilerplate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FfiInstruction<TCallback>andFfiStreamInstruction<TCallback>as generic base classes inRuntime/Scripts/Internal/FfiInstruction.csfor the common one-shot FFI callback pattern (register callback, check error, set IsDone).SetLocalMetadataInstruction,SetLocalNameInstruction,SetLocalAttributesInstruction,UnpublishTrackInstruction, and theWriteInstruction/CloseInstructionpairs in bothTextStreamWriterandByteStreamWriter) with thin subclasses that delegate to the generic base.Test plan
SetMetadata,SetName,SetAttributes,UnpublishTrackstill work in a live roomWriteandCloseoperations still complete correctly🤖 Generated with Claude Code