Remove waiting for agent to connect as part of session.start #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this behavior is still required, it can be replicated by calling `await agent.waitUntilAvailable();` after `await session.start()`. Because the call was made to make `Session` no longer agent specific, I think this change makes sense, though it does to me seem unfortunate that a user would have to do both of those steps. Maybe there's a middle ground like checking if an agent was dispatched as part of the token payload and THEN run this same check, but even that has some amount of magic to it which may not always be what people want in every scenario, so idk.
🦋 Changeset detectedLatest commit: 59e8c58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
I agree that checking for dispatch might actually be the most expected behaviour. It doesn't really solve the case where users dispatch agents outside of the token scope, but expecting an agent to appear if it's part of the token scope seems reasonable |
|
Cool, I will update this change to have that behavior! |
|
Closing in favor of #1225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this behavior is still requested by a user, it can be replicated by calling
await agent.waitUntilAvailable();afterawait session.start().Because the call was made to make
Sessionno longer agent specific, I think this change makes sense, though it does to me seem unfortunate that a user would have to do both of those steps when it is expected to be a relatively common path.Maybe there's a middle ground like checking if an agent was dispatched as part of the token payload and THEN run this same check, but even that has some amount of magic to it which may not always be what people want in every scenario, so idk.