Send eos to appwriter on failure #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
which issue does this resolve? |
davidzhao
reviewed
Oct 13, 2022
| } | ||
|
|
||
| // when a track is killed, one 8x8 frame is sent by the SFU and needs to be ignored | ||
| if pkt != nil { |
Member
Author
There was a problem hiding this comment.
Nope. This was an attempt to get around the final packet and worked for killing a video track, but doesn't work for screen share. The screen share fix of allowing the error and sending an eos to that appwriter also works on regular video tracks
Member
Author
Updated description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes track recordings of screen shares (and is an alternative fix for track disconnection)
Will clean up queue/multiqueue related comments in a separate PR