check for empty client settings #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoonsio
approved these changes
Aug 17, 2025
rektdeckard
approved these changes
Aug 17, 2025
…nd use ctx in the spinner closure
rektdeckard
reviewed
Aug 18, 2025
cmd/lk/agent.go
Outdated
| agentID = lkConfig.Agent.ID | ||
| } else { | ||
| agentID, err = selectAgent(ctx, cmd, false) | ||
| agentID, err = selectAgent(cmd, false) |
Member
There was a problem hiding this comment.
Is there a reason not to propagate ctx? this fn makes network requests, but i guess we're only ever cancelling it via SIGINT/SIGKILL
Contributor
Author
There was a problem hiding this comment.
good point on context, i updated to propogate it to the util.Await function
Member
|
LGTM, is this ready to merge? |
yoonsio
reviewed
Aug 18, 2025
| return nil, err | ||
| } | ||
|
|
||
| if clientSettingsResponse == nil { |
Contributor
There was a problem hiding this comment.
Can we have nil error and nil clientSettingsResponse at the same time?
Member
There was a problem hiding this comment.
good point...i don't think twirp ever does that but i'm not positive
Contributor
Author
There was a problem hiding this comment.
probably not, but doesn't hurt to leave this in so it doesn't panic in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.