-
Notifications
You must be signed in to change notification settings - Fork 126
fix dockerignore and tarball uploads for cloud agents #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…xisting dockerignore
bcherry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks solid and less brittle - do you have a windows machine available to test on?
i don't have a windows machine set up to test this. i added a test run to the GH actions including windows. these new changes pass although there is still some windows issue we need to fix, will address that in a follow-up pr |
adding a test workflow to run on windows, ubuntu, and mac