Skip to content

Conversation

@real-danm
Copy link
Contributor

@real-danm real-danm commented Aug 30, 2025

  • loads the existing dockerignore if there is one
  • uses the project type specific dockerignore if one isn't found
  • add tests to ensure both top-level and subdirs do not include ignored files

adding a test workflow to run on windows, ubuntu, and mac

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks solid and less brittle - do you have a windows machine available to test on?

@real-danm
Copy link
Contributor Author

Code looks solid and less brittle - do you have a windows machine available to test on?

i don't have a windows machine set up to test this. i added a test run to the GH actions including windows. these new changes pass although there is still some windows issue we need to fix, will address that in a follow-up pr

@real-danm real-danm merged commit 7c6f729 into main Aug 30, 2025
8 of 9 checks passed
@real-danm real-danm deleted the dan/fix-dockerignore branch August 30, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants