Skip to content

Remove deprecated and bump protocol version #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keepingitneil merged 2 commits into from
Mar 18, 2026
Merged

Remove deprecated and bump protocol version #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5657c4b
Remove deprecated
keepingitneil Mar 18, 2026
be0bf58
plumbing
keepingitneil Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions cmd/lk/agent_private_link.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,12 @@ var privateLinkCommands = &cli.Command{
},
}

func buildCreatePrivateLinkRequest(name, region string, port uint32, awsEndpoint string) *lkproto.CreatePrivateLinkRequest {
func buildCreatePrivateLinkRequest(name, region string, port uint32, endpoint string) *lkproto.CreatePrivateLinkRequest {
return &lkproto.CreatePrivateLinkRequest{
Name: name,
Region: region,
Port: port,
Config: &lkproto.CreatePrivateLinkRequest_Aws{
Aws: &lkproto.CreatePrivateLinkRequest_AWSCreateConfig{
Endpoint: awsEndpoint,
},
},
Name: name,
Region: region,
Port: port,
Endpoint: endpoint,
}
}

Expand Down
4 changes: 1 addition & 3 deletions cmd/lk/agent_private_link_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ func TestBuildCreatePrivateLinkRequest_HappyPath(t *testing.T) {
assert.Equal(t, "us-east-1", req.Region)
assert.Equal(t, uint32(6379), req.Port)

aws := req.GetAws()
require.NotNil(t, aws)
assert.Equal(t, "com.amazonaws.vpce.us-east-1.vpce-svc-abc123", aws.Endpoint)
assert.Equal(t, "com.amazonaws.vpce.us-east-1.vpce-svc-abc123", req.Endpoint)
}

func TestPrivateLinkServiceDNS(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/go-logr/logr v1.4.3
github.com/go-task/task/v3 v3.44.1
github.com/joho/godotenv v1.5.1
github.com/livekit/protocol v1.45.0
github.com/livekit/protocol v1.45.1
github.com/livekit/server-sdk-go/v2 v2.16.0
github.com/mattn/go-isatty v0.0.20
github.com/moby/patternmatcher v0.6.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,8 @@ github.com/livekit/mediatransportutil v0.0.0-20260309115634-0e2e24b36ee8 h1:coWi
github.com/livekit/mediatransportutil v0.0.0-20260309115634-0e2e24b36ee8/go.mod h1:RCd46PT+6sEztld6XpkCrG1xskb0u3SqxIjy4G897Ss=
github.com/livekit/protocol v1.45.0 h1:e2ubU+rKYegn8f/6SGdKQKVCRfBkK1m0J0Rl5MJmns4=
github.com/livekit/protocol v1.45.0/go.mod h1:63AUi0vQak6Y6gPqSBHLc+ExYTUwEqF/m4b2IRW1iO0=
github.com/livekit/protocol v1.45.1 h1:4cbynsPZW32gS2z6nUWfAfr4YaTUwZSKUiLpSpjX+lQ=
github.com/livekit/protocol v1.45.1/go.mod h1:63AUi0vQak6Y6gPqSBHLc+ExYTUwEqF/m4b2IRW1iO0=
github.com/livekit/psrpc v0.7.1 h1:ms37az0QTD3UXIWuUC5D/SkmKOlRMVRsI261eBWu/Vw=
github.com/livekit/psrpc v0.7.1/go.mod h1:bZ4iHFQptTkbPnB0LasvRNu/OBYXEu1NA6O5BMFo9kk=
github.com/livekit/server-sdk-go/v2 v2.16.0 h1:xbr6PLprgasruzEk4Qv2sHVcK6r+cebUvaHxeE4UsZs=
Expand Down
Loading