Populate client_protocol field in ParticipantInfo#4293
Conversation
📝 WalkthroughWalkthroughUpdates multiple Go module versions and adds the ParticipantInfo.ClientProtocol field population in the RTC participant serialization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pkg/rtc/participant.go
Outdated
| Kind: grants.GetParticipantKind(), | ||
| KindDetails: grants.GetKindDetails(), | ||
| DisconnectReason: p.CloseReason().ToDisconnectReason(), | ||
| ClientProtocol: p.params.ClientInfo.ClientInfo.GetClientProtocol(), |
There was a problem hiding this comment.
just doublechecking - this (p.params.ClientInfo.ClientInfo) can't be nil - right?
There was a problem hiding this comment.
It should not be, but good point, will add a check
Summary by CodeRabbit