Skip to content

feat: Add DecodeRTPEndBit for DTMF decoding without Marker bit requirement#46

Merged
dennwc merged 5 commits intolivekit:mainfrom
usluio:usluio/rfc4733-endbit-decode
Mar 17, 2026
Merged

feat: Add DecodeRTPEndBit for DTMF decoding without Marker bit requirement#46
dennwc merged 5 commits intolivekit:mainfrom
usluio:usluio/rfc4733-endbit-decode

Conversation

@usluio
Copy link
Copy Markdown
Contributor

@usluio usluio commented Feb 10, 2026

Summary

Adds DecodeRTPEndBit, an alternative DTMF RTP decoding function that uses the RFC 4733 End bit instead of the Marker bit to determine event completion.

Problem

The existing DecodeRTP requires the RTP Marker bit to be set on incoming DTMF packets. Many SIP providers/gateways do not consistently set the Marker bit (RFC 4733 §2.3.1), causing DTMF events to be silently dropped.

Solution

Added DecodeRTPEndBit as an alternative decoding mode:

func DecodeRTPEndBit(h *rtp.Header, payload []byte) (Event, bool)

@usluio usluio requested review from a team as code owners February 10, 2026 12:26
@usluio
Copy link
Copy Markdown
Contributor Author

usluio commented Feb 10, 2026

:) @dennwc thx

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 10, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@biglittlebigben
Copy link
Copy Markdown
Contributor

I will defer to the telephony team for feedback on the core of the patch, bur please cleanup the imports before we can consider this.

@usluio
Copy link
Copy Markdown
Contributor Author

usluio commented Feb 17, 2026

I will defer to the telephony team for feedback on the core of the patch, bur please cleanup the imports before we can consider this.

Resolved

Comment thread dtmf/dtmf.go Outdated
Comment thread dtmf/dtmf.go Outdated
Comment thread dtmf/dtmf.go Outdated
Comment thread dtmf/dtmf.go Outdated
@dennwc dennwc force-pushed the usluio/rfc4733-endbit-decode branch from ae2ba4b to 98bbcb6 Compare March 17, 2026 11:35
@dennwc dennwc merged commit ad60395 into livekit:main Mar 17, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants