Conversation
🦋 Changeset detectedLatest commit: 523f0f4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm going to apply this fix to agent-js after this fix is released. Also I will do the documentation improvement on that. |
Shubhrakanti
left a comment
Shubhrakanti
left a comment
There was a problem hiding this comment.
This makes sense to me.
| return this.info?.muted; | ||
| } | ||
|
|
||
| async close() { |
There was a problem hiding this comment.
should we have a optional boolean here to also close the source when closing the track? e.g.
async close(closeSource = true) {
There was a problem hiding this comment.
@Shubhrakanti @bcherry I'm not familiar with JS side but this sounds fair to me. What do you think?
I'm going to merge this pr but I'm open to implement this in a different pr
There was a problem hiding this comment.
This makes sense to me!
There was a problem hiding this comment.
Thanks, I will create an other pr for it!
|
The CI for Windows failed. Re-running is no luck. But I tried it with |
4 participants
It's actually an issue on Track side where it keep a reference for AudioSource and needs to be disposed