Merged
Conversation
Contributor
boks1971
commented
Mar 26, 2025
boks1971
commented
- Introducing a rate shape that captures rate of different metrics in a given interval. The interval is contained in that message.
- Stats can have multiple rates. This is akin to reporting different window load avg in unix systems.
- Clean up a few things o sys packets pct in rate (not sure what it was capturing) o associated prom metric (this is in server code which will come in a separate PR) (was not used anywhere internally, don't think external projects would be using it either)
- Introducing a rate shape that captures rate of different metrics in a
given interval. The interval is contained in that message.
- Stats can have multiple rates. This is akin to reporting different
window load avg in unix systems.
- Clean up a few things
o sys packets pct in rate (not sure what it was capturing)
o associated prom metric (this is in server code which will come in a
separate PR) (was not used anywhere internally, don't
think external projects would be using it either)
🦋 Changeset detectedLatest commit: ce58c6d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
boks1971
added a commit
to livekit/livekit
that referenced
this pull request
Mar 26, 2025
Related protocol PR - livekit/protocol#1023 - Make a config for node stats measurements. Wanted to put the config in `routing` package, but a circular dependency forced me to put in config.go - Make rate calculations explicit, i. e. requested via config. Previously, it had some odd checks to decide when to calculate rate and it would have been calculating over different windows. - Report signal/data channel bytes every 5 seconds to stats collection module. Previously, it was doing it every 30 seconds and that meant some windows could have had a large spike NOTE: Still need to think about this for load calculations as a large number of participants leaving could flush in a small window and that could report a large spike in bytes/packets. Maybe need to ignore signal bytes for load calculation?
cnderrauber
approved these changes
Mar 26, 2025
paulwe
approved these changes
Mar 26, 2025
boks1971
added a commit
to livekit/livekit
that referenced
this pull request
Mar 27, 2025
* Rework node stats a bit. Related protocol PR - livekit/protocol#1023 - Make a config for node stats measurements. Wanted to put the config in `routing` package, but a circular dependency forced me to put in config.go - Make rate calculations explicit, i. e. requested via config. Previously, it had some odd checks to decide when to calculate rate and it would have been calculating over different windows. - Report signal/data channel bytes every 5 seconds to stats collection module. Previously, it was doing it every 30 seconds and that meant some windows could have had a large spike NOTE: Still need to think about this for load calculations as a large number of participants leaving could flush in a small window and that could report a large spike in bytes/packets. Maybe need to ignore signal bytes for load calculation? * deps * use default node stats config if given config is nil * split out node stats into a struct for re-use * update config
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.