ensure access token do not contain sensitive credentials#1097
ensure access token do not contain sensitive credentials#1097
Conversation
🦋 Changeset detectedLatest commit: 7a7d801 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| if c.Egress.Participant != nil { | ||
| for _, output := range c.Egress.Participant.FileOutputs { | ||
| if err := checkOutputForCredentials(output.Output); err != nil { | ||
| return err |
There was a problem hiding this comment.
https://pkg.go.dev/slices#ContainsFunc
Cleaner to use this instead of the for loop
There was a problem hiding this comment.
I'm not seeing that.. I need to capture the error, not just checking for if it passes a boolean check
There was a problem hiding this comment.
Ah yes good point, let me try to come up with something
There was a problem hiding this comment.
How does this look? All tests pass.
There was a problem hiding this comment.
The diff in GH UI looks all over the place, probably worth it to open the file directly
There was a problem hiding this comment.
personally, I'm not a huge fan of using reflections when alternatives exists. it's less code, but much harder to read.
4 participants
No description provided.