Detailed responses in trunk iter#1101
Merged
nishadmusthafa merged 3 commits intomainfrom Jun 10, 2025
Merged
Conversation
Contributor
nishadmusthafa
commented
Jun 10, 2025
nishadmusthafa
commented
- No trunks are configured
- Trunks are configured but none matched.(This can happen when there is no default trunk)
- There is a default trunk that got applied
- A specific trunk matched
This will help discern between cases when 1. No trunks are configured 2. Trunks are configured but none matched.(This can happen when there is no default trunk) 3. There is a default trunk that got applied 4. A specific trunk matched
🦋 Changeset detectedLatest commit: c1ff3fc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dennwc
approved these changes
Jun 10, 2025
| } | ||
|
|
||
| // MatchTrunkIterDetailed is like MatchTrunkIter but returns detailed match information | ||
| func MatchTrunkIterDetailed(it iters.Iter[*livekit.SIPInboundTrunkInfo], call *rpc.SIPCall, opts ...MatchTrunkOpt) (*TrunkMatchResult, error) { |
Contributor
There was a problem hiding this comment.
Just a nit, but you could drop Iter from the name, if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.