Skip to content

Filling out some messages that are unlikely to change in v2. #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025
Merged

Filling out some messages that are unlikely to change in v2. #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa82c17
Filling out some messages that are unlikely to change in v2.
boks1971 Jul 21, 2025
7a114aa
generated protobuf
github-actions[bot] Jul 21, 2025
52ae8c6
comment
boks1971 Jul 21, 2025
ba4e7f8
mage
boks1971 Jul 21, 2025
823408f
generated protobuf
github-actions[bot] Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions livekit/livekit_rtc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

177 changes: 147 additions & 30 deletions livekit/livekit_rtc_v2.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ message DataPacket {
}

message ActiveSpeakerUpdate {
option deprecated = true;
repeated SpeakerInfo speakers = 1;
}

Expand Down
4 changes: 2 additions & 2 deletions protobufs/livekit_rtc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ import "livekit_models.proto";

message SignalRequest {
oneof message {
// initial join exchange, for publisher
// participant offer for publisher
SessionDescription offer = 1;
// participant answering publisher offer
// participant answering subscriber offer
SessionDescription answer = 2;
TrickleRequest trickle = 3;
AddTrackRequest add_track = 4;
Expand Down
6 changes: 6 additions & 0 deletions protobufs/livekit_rtc_v2.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ message Signalv2ClientMessage {

oneof message {
ConnectRequest connect_request = 2;
SessionDescription publisher_sdp = 3; // SDP offer for publisher peer connection
SessionDescription subscriber_sdp = 4; // SDP answer for subscriber peer connection
}
}

Expand All @@ -58,6 +60,10 @@ message Signalv2ServerMessage {

oneof message {
ConnectResponse connect_response = 2;
SessionDescription publisher_sdp = 3; // SDP answer for publisher peer connection
SessionDescription subscriber_sdp = 4; // SDP offer for subscriber peer connection
RoomUpdate room_update = 5;
ParticipantUpdate participant_update = 6;
}
}

Expand Down