-
Notifications
You must be signed in to change notification settings - Fork 121
feat(sip): Add numbers field to SIPDispatchRuleInfo for filtering calls by called number
#1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sip): Add numbers field to SIPDispatchRuleInfo for filtering calls by called number
#1351
Conversation
🦋 Changeset detectedLatest commit: f7d1e71 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
dennwc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good! Updating SIP should automatically start using the new rules, but Cloud will need some extra work on our end to support this.
We were actually planning to redo the trunk/rules in a new API, so this use case may be covered in it already. But I'm not opposed to adding this extension for the current API in the meantime.
Curious what other team members think.
…alls by called number - Add `numbers` field to filter calls by the called number (trunk number) - Include `numbers` in dispatch rule priority calculation and validation - Update dispatch rule matching logic to check both inbound and called numbers - Add tests for number-specific dispatch rules and conflicts
05aadcb to
9af2ae5
Compare
|
Hello @nishadmusthafa, |
|
hey @civilcoder55 , as @dennwc long term we will be moving to a different mechanism for dispatch rules that will be more flexible way to handle this use case. I'm also fine for this being a way to handle that until then. This was an attempt some time back at that solution which we haven't been able to prioritise |
|
Thank you @nishadmusthafa |
numbersfield to filter calls by the called number (trunk number)numbersin dispatch rule priority calculation and validationMotivation:
Previously, when a trunk had multiple numbers and calls from each number needed to be dispatched to a different agent, a separate trunk had to be created for each number and linked to its own dispatch rule.
This change allows dispatch rules to be matched directly against trunk numbers (derived from the SIP
Toheader). As a result, a single trunk can now contain multiple numbers, with each number correctly routed using its own dispatch rule.