Skip to content

TEL-543: same trunk can match duplicate normalized SIP numbers#1514

Merged
hechen-eng merged 1 commit intomainfrom
trunk_match_fix
Apr 24, 2026
Merged

TEL-543: same trunk can match duplicate normalized SIP numbers#1514
hechen-eng merged 1 commit intomainfrom
trunk_match_fix

Conversation

@hechen-eng
Copy link
Copy Markdown
Contributor

No description provided.

@hechen-eng hechen-eng requested a review from a team April 23, 2026 22:13
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

⚠️ No Changeset found

Latest commit: 6ab90a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Copy Markdown
Contributor

@alexlivekit alexlivekit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

Do we want to run that check when updating the definition as well?

regardless, lgtm

@hechen-eng
Copy link
Copy Markdown
Contributor Author

hechen-eng commented Apr 24, 2026

nice.

Do we want to run that check when updating the definition as well?

regardless, lgtm

yeah, I think we should do that 👍

Let me do it in a separate PR though.

@hechen-eng hechen-eng merged commit 2a2b6db into main Apr 24, 2026
9 checks passed
@hechen-eng hechen-eng deleted the trunk_match_fix branch April 24, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants