Adding ability to specify per-trunk media timeouts#1534
Conversation
🦋 Changeset detectedLatest commit: f07fae1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@alexlivekit lets lend it after #1530 and move the media timeout into the new |
|
|
||
| // NEXT ID: 24 | ||
| // Per-call RTP media timeout; if unset, SIP service defaults apply. | ||
| google.protobuf.Duration media_timeout = 24; |
There was a problem hiding this comment.
Do we want to allow overriding the initial media timeout as well?
There was a problem hiding this comment.
that was the initial approach, but opted out of it for now - this is mainly for oddball hold behavior, which happens after setup.
alexlivekit
force-pushed
the
alexmigolin/tel-565-allow-customers-to-specify-media-timeout
branch
from
a4f3941 to
7800297
Compare
alexlivekit
force-pushed
the
alexmigolin/tel-565-allow-customers-to-specify-media-timeout
branch
from
7800297 to
ed81a8f
Compare
| applyListUpdate(&info.TrunkIds, p.TrunkIds) | ||
| applyUpdatePtr(&info.Rule, p.Rule) | ||
| applyUpdatePtr(&info.Media, p.Media) | ||
| applyUpdatePtr(&info.Media, p.Media) // TODO: Consider applying partial updates |
There was a problem hiding this comment.
@dennwc , we might need to revisit this to avoid it being a pain long term
| func (p *SIPMediaEncryption) Deref() SIPMediaEncryption { | ||
| if p == nil { | ||
| return SIPMediaEncryption_SIP_MEDIA_ENCRYPT_DISABLE | ||
| } | ||
| return *p | ||
| } |
alexlivekit
deleted the
alexmigolin/tel-565-allow-customers-to-specify-media-timeout
branch
3 participants
No description provided.