Skip to content

Expose Logger constructor for Zap#701

Merged
dennwc merged 2 commits intomainfrom
zap-log
May 1, 2024
Merged

Expose Logger constructor for Zap#701
dennwc merged 2 commits intomainfrom
zap-log

Conversation

@dennwc
Copy link
Copy Markdown
Contributor

@dennwc dennwc commented Apr 30, 2024

As per the community request, expose the Logger constructor for a pre-configured Zap logger.

@dennwc dennwc self-assigned this Apr 30, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 96d962b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Comment thread logger/logger.go Outdated
Copy link
Copy Markdown
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dennwc dennwc merged commit 151d757 into main May 1, 2024
@dennwc dennwc deleted the zap-log branch May 1, 2024 10:27
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants