Merged
Conversation
🦋 Changeset detectedLatest commit: 21e4566 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
paulwe
approved these changes
Jul 2, 2024
biglittlebigben
force-pushed
the
benjamin/agents2
branch
from
db995dd to
87611af
Compare
biglittlebigben
force-pushed
the
benjamin/agents2
branch
from
3e09e04 to
a327921
Compare
biglittlebigben
force-pushed
the
benjamin/agents2
branch
from
03f8802 to
c2a9d77
Compare
davidzhao
reviewed
Jul 3, 2024
| rpc CreateAgentJobDefinition(CreateAgentJobDefinitionRequest) returns (JobDefinition); | ||
| rpc DeleteAgentJobDefinition(DeleteAgentJobDefinitionRequest) returns (JobDefinition); | ||
| rpc ListAgentJobDefinitions(ListAgentJobDefinitionsRequesst) returns (ListAgentJobDefinitionsResponse); | ||
| rpc CreateAgentDispatch(CreateAgentDispatchRequest) returns (AgentDispatch); |
Member
There was a problem hiding this comment.
I'm liking Dispatch! i think it's more straight forward to understand.
nit: should we drop the Agent from the method name? i.e.
Suggested change
| rpc CreateAgentDispatch(CreateAgentDispatchRequest) returns (AgentDispatch); | |
| rpc CreateDispatch(AgentCreateDispatchRequest) returns (AgentDispatch); |
biglittlebigben
force-pushed
the
benjamin/agents2
branch
from
58cb67a to
0c723ab
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes some feedback on the agents protocol:
This also allows setting a room configuration in the token.