Conversation
🦋 Changeset detectedLatest commit: 45b14e5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| // Max call duration. | ||
| google.protobuf.Duration max_call_duration = 12; | ||
|
|
||
| bool krisp_enabled = 13; |
There was a problem hiding this comment.
What is the motivation to use boolean here rather than with a repeated feature field like for the rpc?
There was a problem hiding this comment.
I did it here because it's specific to SIPInboundTrunkInfo, while future features might not apply
There was a problem hiding this comment.
supported vs unsupported features can be dealt with request validation early in the request processing. Unique booleans for each feature will require us to keep adding fields to the messages, which may become quite long. It would work from a functionality perspective though, of course. Curious what other folks think.
There was a problem hiding this comment.
it seems clearer to have the Trunk definition to be explicit and flat.
| // Max call duration. | ||
| google.protobuf.Duration max_call_duration = 12; | ||
|
|
||
| bool krisp_enabled = 13; |
There was a problem hiding this comment.
it seems clearer to have the Trunk definition to be explicit and flat.
3 participants
No description provided.