Skip to content

Participant joined_at_ms to get higher resolution of join time.#949

Merged
boks1971 merged 2 commits intomainfrom
raja_joined_at_ms
Jan 22, 2025
Merged

Participant joined_at_ms to get higher resolution of join time.#949
boks1971 merged 2 commits intomainfrom
raja_joined_at_ms

Conversation

@boks1971
Copy link
Contributor

@boks1971 boks1971 commented Jan 22, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1576bb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@boks1971 boks1971 requested a review from a team January 22, 2025 08:14
@boks1971 boks1971 merged commit 18fcdd8 into main Jan 22, 2025
@boks1971 boks1971 deleted the raja_joined_at_ms branch January 22, 2025 08:18
@bcherry
Copy link
Contributor

bcherry commented Jan 22, 2025 •
edited
Loading

would it make sense to add a Room.creation_time_ms while we're at it? the client SDKs consume these in the same way and I also imagine there are developers doing math on room creation time vs participant join time so they should have the same resolution...

@boks1971
Copy link
Contributor Author

boks1971 commented Jan 23, 2025

Will look at adding that @bcherry . One note though. room creation time and participant join time could be using different clocks in cloud as they could be on different nodes. But, it should be within the clock skew of servers which is probably okay for the kind of comparisons you have mentioned.

boks1971 added a commit that referenced this pull request Jan 23, 2025
@boks1971
Room creation time with ms resolution.
fccb6aa 
Follow up to this PR - #949 and
this comment - #949 (comment)
@boks1971 boks1971 mentioned this pull request Jan 23, 2025
Merged
@boks1971
Copy link
Contributor Author

boks1971 commented Jan 23, 2025

Protocol change PR - #950

boks1971 added a commit that referenced this pull request Jan 23, 2025
@boks1971 @github-actions
Room creation time with ms resolution. (#950)
6ec1903 
* Room creation time with ms resolution.

Follow up to this PR - #949 and
this comment - #949 (comment)

* generated protobuf

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnderrauber cnderrauber cnderrauber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boks1971 @bcherry @cnderrauber