Add max round trip latency#1127
Merged
Merged
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
1egoman
commented
Jun 2, 2026
1 task
ladvoc
approved these changes
Jun 2, 2026
lukasIO
reviewed
Jun 3, 2026
Co-authored-by: lukasIO <mail@lukasseiler.de>
lukasIO
approved these changes
Jun 3, 2026
Contributor
Author
|
@ladvoc Before merging, any preference on The benefit of the latter is something like a serde value just works (ie, |
Contributor
I would go with |
Merged
1egoman
pushed a commit
that referenced
this pull request
Jun 3, 2026
> [!IMPORTANT] > Merging this pull request will create these releases # livekit 0.7.44 (2026-06-03) ## Features - Add rpc max_round_trip_latency and move to builder pattern - #1127 (@1egoman) ## Fixes - [allow(dead_code)] for dead function in room module - #1128 (@stephen-derosa) - Send publisher offer with join request to accelerate connection - #996 (@cnderrauber) # livekit-api 0.5.1 (2026-06-03) ## Fixes - Send publisher offer with join request to accelerate connection - #996 (@cnderrauber) # livekit-ffi 0.12.62 (2026-06-03) ## Fixes - Add rpc max_round_trip_latency and move to builder pattern - #1127 (@1egoman) - [allow(dead_code)] for dead function in room module - #1128 (@stephen-derosa) - Send publisher offer with join request to accelerate connection - #996 (@cnderrauber) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
max_round_trip_latencyfield toPerformRpcData, adding similar behavior as was added to the corresponding swift and android pull requests.Note that this is a breaking api change. Per @ladvoc's guidance, this was deemed to be ok because there isn't really a great way to add this new field to the
PerformRpcDatastruct in a backwards compatible way.Given this is a breaking change, I opted to break it in a way where if we have to add more fields in here in the future, it could be done in a non breaking way by making
PerformRpcDatause a builder pattern. That results in something that looks like: