-
Notifications
You must be signed in to change notification settings - Fork 137
Add a request_async_id to the async requests #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a request_async_id to the async requests #842
Conversation
📝 WalkthroughWalkthroughThis PR extends multiple protobuf request messages across the FFI protocol with an optional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
🔇 Additional comments (31)
✏️ Tip: You can disable this entire section by setting Comment |
cloudwebrtc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ladvoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅, just a few unnecessary clones that should be removed prior to merging.
e871581 to
1668e49
Compare
This PR will allows client SDKs to generate an async id for the async requests, and start a listener before passing the requests, so that it could fix the race conditions.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.