Skip to content

Propagate original SIP response status text. #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Propagate original SIP response status text. #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkg/sip/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,13 +777,19 @@ authLoop:
case sip.StatusOK:
break authLoop
default:
return nil, fmt.Errorf("unexpected status from INVITE response: %w", &livekit.SIPStatus{Code: livekit.SIPStatusCode(resp.StatusCode)})
return nil, fmt.Errorf("unexpected status from INVITE response: %w", &livekit.SIPStatus{
Code: livekit.SIPStatusCode(resp.StatusCode),
Status: resp.Reason,
})
case sip.StatusBadRequest,
sip.StatusNotFound,
sip.StatusTemporarilyUnavailable,
sip.StatusNotAcceptableHere,
sip.StatusBusyHere:
err := &livekit.SIPStatus{Code: livekit.SIPStatusCode(resp.StatusCode)}
err := &livekit.SIPStatus{
Code: livekit.SIPStatusCode(resp.StatusCode),
Status: resp.Reason,
}
if body := resp.Body(); len(body) != 0 {
err.Status = string(body)
} else if s := resp.GetHeader("X-Twillio-Error"); s != nil {
Expand Down
5 changes: 4 additions & 1 deletion pkg/sip/protocol.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,10 @@ func sendRefer(ctx context.Context, c Signaling, req *sip.Request, stop <-chan s
case sip.StatusOK, 202: // 202 is Accepted
return resp, nil
default:
return resp, &livekit.SIPStatus{Code: livekit.SIPStatusCode(resp.StatusCode)}
return resp, &livekit.SIPStatus{
Code: livekit.SIPStatusCode(resp.StatusCode),
Status: resp.Reason,
}
}
}

Expand Down