Send SDP with 200 OK for a reinvite. #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlivekit
reviewed
Nov 13, 2025
Comment on lines
+1599
to
+1600
| c.mu.RLock() | ||
| defer c.mu.RUnlock() |
Contributor
There was a problem hiding this comment.
This is just here to explicitly create a memory barrier, right?
Contributor
Author
There was a problem hiding this comment.
Right, the slices is ~24 bytes wide, so it won't be an atomic read.
But in general, in Go it's better to always lock things. Compiler could be aggressive when optimizing and it's safer to assume that the state will be used by other goroutines sooner or later. It may lead to very subtle bugs if we rely on implicit atomic reads.
alexlivekit
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.