Skip to content

nodes(transcription): allow up to 192000 sample rate, default to 16000khz for whisper#42

Merged
eliteprox merged 1 commit intomainfrom
fix/sample-rate-default-max
Sep 12, 2025
Merged

nodes(transcription): allow up to 192000 sample rate, default to 16000khz for whisper#42
eliteprox merged 1 commit intomainfrom
fix/sample-rate-default-max

Conversation

@eliteprox
Copy link
Copy Markdown
Collaborator

@eliteprox eliteprox commented Sep 12, 2025

ComfyUI has a default int max of 2048. This modifies the AudioTranscriptionNode node to allow up 192000khz sample rate values and sets a default of 16000Khz.

Clears the Whisper warnings
2025-09-12 21:29:33 [WARNING] [ComfyUI-Stream-Pack.src.audio_transcription.transcription_nodes] [transcription_nodes.py:481] Non-optimal sample rate 1600Hz for Whisper (16kHz recommended)

@eliteprox eliteprox requested a review from pschroedl September 12, 2025 21:41
@eliteprox
Copy link
Copy Markdown
Collaborator Author

Used in workflow for PR livepeer/comfystream#388

Copy link
Copy Markdown

@pschroedl pschroedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliteprox eliteprox merged commit 011da8e into main Sep 12, 2025
@eliteprox eliteprox deleted the fix/sample-rate-default-max branch September 12, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants