avfilter: New scene classification filter#9
Merged
jailuthra merged 7 commits intojai/ffmpeg-v4.4-workingfrom Aug 5, 2021
Merged
avfilter: New scene classification filter#9jailuthra merged 7 commits intojai/ffmpeg-v4.4-workingfrom
jailuthra merged 7 commits intojai/ffmpeg-v4.4-workingfrom
Conversation
Works combined with hwdownload,format=nv12 if NVDEC is used.
jailuthra
commented
Aug 2, 2021
Author
jailuthra
left a comment
jailuthra
left a comment
There was a problem hiding this comment.
Made some self-review comments to help other reviewers:
yondonfu
reviewed
Aug 3, 2021
Member
yondonfu
left a comment
yondonfu
left a comment
There was a problem hiding this comment.
Awesome to see how much less code we need for the livepeer_dnn filter since we can take advantage of the recent updates to the DNN backend APIs in ffmpeg!
jailuthra
force-pushed
the
jai/ffmpeg-v4.4
branch
2 times, most recently
from
72868f4 to
8d3e09a
Compare
This is required, as without it Tensorflow doesn't initialize input/output tensors - and we end up spending that precious time at the start of the first incoming frame.
jailuthra
force-pushed
the
jai/ffmpeg-v4.4
branch
from
8d3e09a to
74a0c3e
Compare
jailuthra
force-pushed
the
jai/ffmpeg-v4.4
branch
from
74a0c3e to
c83669b
Compare
yondonfu
approved these changes
Aug 5, 2021
Member
yondonfu
left a comment
yondonfu
left a comment
There was a problem hiding this comment.
LGTM!
Just one comment about commit structure - feel free to consider and address during merge process.
jailuthra
commented
Aug 5, 2021
jailuthra
added a commit
to livepeer/lpms
that referenced
this pull request
Aug 6, 2021
On top of v4.4, the new branch contains some critical fixes needed for our transcoding pipeline - like flushing buffers of NVENC. It also contains a refactored scene classification DNN filter: livepeer/FFmpeg#9
ad-astra-video
pushed a commit
to ad-astra-video/FFmpeg
that referenced
this pull request
Feb 25, 2024
Co-authored-by: Oscar <oscar_davids@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
livepeer/lpms#248
What?
vf_lvpdnnfilter withvf_livepeer_dnnwhich is simpler, and uses the newer APIs in ffmpeg v4.4TODO