Skip to content

event logger code added#1

Open
heypran wants to merge 1 commit intolivepeer:masterfrom
heypran:livepeer-event-logger
Open

event logger code added#1
heypran wants to merge 1 commit intolivepeer:masterfrom
heypran:livepeer-event-logger

Conversation

@heypran
Copy link

@heypran heypran commented Oct 24, 2018

Initial code for livepeer event logger

@ericxtang
Copy link
Member

A few comments:

  1. The package should have de-duplication when writing into the database, so events won't be logged twice.
  2. db should be configurable, so it's not saving to the Admin db.

@heypran
Copy link
Author

heypran commented Oct 29, 2018

  1. Agree will add that soon
  2. I believe it depends on the URI / userRole which someone uses to plugin with this code. As there is no database attached to the code. Its plug and play

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants