runner/live: Refactor pipeline streamer and add some docs #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inheritance was so ugly and got in the way several times.
victorges
force-pushed
the
vg/refact/live-app-cleanup
branch
from
ea9aeb0 to
64e88a5
Compare
eliteprox
approved these changes
Dec 4, 2024
Collaborator
eliteprox
left a comment
eliteprox
left a comment
There was a problem hiding this comment.
LGTM! It's a nice cleanup and improves logging and documentation. Tested start/update stream from gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few slightly unrelated refactors to improve general code quality and maintainability on
the live runner code. Specifically:
t_index_ratio_listwhich was only helpful back when I was doing updates manually on a JSONPipelinebase class, helpful for pipeline implementors