add build of dynamic trt dreamshaper engine#522
Merged
Conversation
pschroedl
requested review from
Copilot,
eliteprox,
pwilczynskiclearcode and
victorges
eliteprox
requested changes
Apr 10, 2025
Collaborator
There was a problem hiding this comment.
LGTM! We just need to update the sha hash for comfyui-base here
The image tag with necessary build_trt.py changes is livepeer/comfyui-base@sha256:13f3469396d8ed873c3d8cc3afabb51e3f62841dba661eccedc9a73acf7644a9
eliteprox
force-pushed
the
dynamic_tensorrt_dreamshaper
branch
from
4e243c5 to
e90a6f9
Compare
eliteprox
approved these changes
Apr 10, 2025
|
|
||
| # Dreamshaper-8-Dmd-1kstep static dynamic 488x704 | ||
| # TODO(pschroedl): Remove the script download with curl. | ||
| # It will be present in the base image once https://github.com/livepeer/comfystream/pull/107 is merged |
Contributor
There was a problem hiding this comment.
It's already merged
pwilczynskiclearcode
approved these changes
Apr 11, 2025
eliteprox
force-pushed
the
dynamic_tensorrt_dreamshaper
branch
from
af68769 to
212cc49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates dl_checkpoints with a build of a dynamic version of the dreamshaper tensorrt engine supporting vertical/horizontal resolutions of 704x448