Send analytics logs to Kafka #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Victor Elias <victor@livepeer.org>
thomshutt
approved these changes
Mar 6, 2024
| sumRebufferRate += mv.sumRebufferRate / float64(mv.count) | ||
| var msgs []kafka.Message | ||
| for _, d := range p.logs { | ||
| key, err := json.Marshal(KafkaKey{SessionID: d.SessionID, EventType: d.EventType}) |
Contributor
There was a problem hiding this comment.
optimization:
no need to send JSON as a key. it could be simply:
key := []byte(d.SessionID + d.EventType)
Contributor
Author
There was a problem hiding this comment.
Hmm, currently we set the JSON schema for the key, so I guess this won't work. We could consider not having the schema and just using the concatenated string instead.
Contributor
There was a problem hiding this comment.
nvm then. No need for pre-optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fix https://linear.app/livepeer/issue/ENG-1702/send-raw-analytics-logs-to-kafka