chore: add stricter linting, import sorting, and prettier#385
Merged
ECWireless merged 13 commits intomainfrom Nov 23, 2025
Merged
chore: add stricter linting, import sorting, and prettier#385ECWireless merged 13 commits intomainfrom
ECWireless merged 13 commits intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces stricter linting, import sorting with eslint-plugin-simple-import-sort, and Prettier formatting across the codebase. The changes primarily focus on code style improvements including:
- Standardized import ordering (external dependencies first, then internal imports, with blank lines separating groups)
- Consistent formatting with Prettier (2-space indentation, double quotes, trailing commas)
- Replacement of CSS shorthand properties with explicit names (e.g.,
p→padding,mb→marginBottom) - Enhanced type safety in several components
Key Changes
- Added ESLint import sorting plugin and Prettier configuration
- Updated dependency arrays in React hooks to include all dependencies
- Improved type annotations in components like
Claim,VotingWidget, andDelegatingWidget - Cleaned up unused imports and variables throughout the codebase
Reviewed Changes
Copilot reviewed 114 out of 119 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | Added import sorting rules and Prettier integration |
| prettier.config.mjs | New Prettier configuration with project standards |
| package.json | Added Prettier and import sorting dependencies, new format scripts |
| apollo/createSchema.ts | Removed await from introspectSchema (bug introduced) |
| components/Claim/index.tsx | Added proper type annotations for proof and migration parameters |
| components/CircularProgressBar/index.tsx | Fixed children prop usage |
| components/DelegatingWidget/Input.tsx | Corrected useMemo dependency array |
| components/PerformanceList/index.tsx | Updated useMemo dependencies |
| pages/voting/create-poll.tsx | Added config to useEffect dependency array |
| pages/migrate/broadcaster.tsx | Changed Math.random() key to constant (questionable pattern) |
| All other files | Import sorting, formatting, and CSS property name expansions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
87fb588 to
498705d
Compare
Jipperism
reviewed
Nov 21, 2025
Member
|
Truly amazing! Thanks. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyfor now, but this will be dealt with in Add Husky pre-commit and push checks #343 )AI Summary
This pull request introduces a variety of improvements and code quality enhancements across multiple components, with a focus on code consistency, type safety, and maintainability. The most notable changes include updates to styling conventions, improved TypeScript typing, import order standardization, and better handling of contract interactions.
Styling and Code Consistency
p,py,pl,pr,mr,pt,pb,px) with explicit property names likepadding,paddingTop,paddingBottom,paddingLeft,paddingRight, andmarginRightacross several components for improved clarity and consistency. [1] [2] [3] [4] [5] [6]bctobackgroundColorfor clarity inActiveCircle.Type Safety and Logic Improvements
Claimcomponent by specifying types forproofandmigrationParams, initializing defaults, and ensuring correct types are passed to contract calls. [1] [2] [3]Footercomponent's type definitions, making theresetfunction signature explicit and clarifying union and optional types for props. [1] [2]Import Order and Code Hygiene
l1MigratorandgetL1MigratorAddressfrom theClaimcomponent.Miscellaneous Improvements
.prettierignorefile to exclude build artifacts, dependencies, and miscellaneous files from formatting, helping maintain a clean codebase.README.mdfor consistency.createSchemaby removing unnecessaryawait.Inputcomponent to ensure correct recalculation when relevant props change.CircularProgressBarfor correctness.These changes collectively improve code readability, maintainability, and robustness, setting a better foundation for future development.